search

KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

Fixed Links in song suggestion pagination #320

Closed vivsh1999 closed 2 years ago

vivsh1999 commented 2 years ago

🛠️ Fixes Issue

Fixes #314

Related Issue/Addition to code

👨‍💻 Changes proposed

I have changed the logic to show links a bit by adding a start pivot so that it always keeps track of the page.

Type of change

✔️ Check List (Check all the applicable boxes)

📄 Note to reviewers

The start variable will be always the index of the first item i.e 0,5,10,... respectively for each page

📷 Screenshots

Not a visible change but tested the links locally, its working supposedly

netlify[bot] commented 2 years ago

Deploy Preview for mogulchristmas ready!

Name Link
Latest commit 28bd64f1a0bb0115c864f6fbe996caa96a5fcc19
Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/6314d80b0a69190008160fcc
Deploy Preview https://deploy-preview-320--mogulchristmas.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vivsh1999 commented 2 years ago

I am doing a refractor. Code quality is low in this file. @KendallDoesCoding

KendallDoesCoding commented 2 years ago

I am doing a refractor. Code quality is low in this file. @KendallDoesCoding

Ok.. Yes, I didn't know JS at that time (still don't know it well) and a contributor made the PR so I couldn't understand what it did but it worked with the functionality properly at that time, but over time updating the files, the functionality stopped, hence I created #314.

I really appreciate your help @sharmavivek223

vivsh1999 commented 2 years ago

I am doing a refractor. Code quality is low in this file. @KendallDoesCoding

Ok.. Yes, I didn't know JS at that time (still don't know it well) and a contributor made the PR so I couldn't understand what it did but it worked with the functionality properly at that time, but over time updating the files, the functionality stopped, hence I created #314.

I really appreciate your help @sharmavivek223

It's alright @KendallDoesCoding, we are all learning every day. I have made changes and tested on my end

KendallDoesCoding commented 2 years ago

we are all learning every day

Indeed!! Thanks for understanding

vivsh1999 commented 2 years ago

It would work now @KendallDoesCoding

vivsh1999 commented 2 years ago

Now anyone can easily add new songs to that list without breaking code, also can be moved to API in future easily

KendallDoesCoding commented 2 years ago

Now anyone can easily add new songs to that list without breaking code, also can be moved to API in future easily

yes. thanks to you!!

KendallDoesCoding commented 2 years ago

@all-contributors please add @sharmavivek223 to the doc

allcontributors[bot] commented 2 years ago

@KendallDoesCoding

I've put up a pull request to add @sharmavivek223! :tada: