search

KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

Improve Design Done #358

Closed 93Belen closed 1 year ago

93Belen commented 1 year ago

Hey! I finished the Design! I did the desktop and mobile version. I hope you like it :) Apart from the snow effect, I also added a couple of silly animations that come out after a minute in the home page and the lyrics page. Kind of an Easter egg. You can see all the changes in this video. https://youtu.be/DhoWxG1Fzjg

netlify[bot] commented 1 year ago

Deploy Preview for mogulchristmas ready!

Name Link
Latest commit d12814269d051b1855a9f3f5c065cfdb75a5c2ae
Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/6416ee8152ae2c00081884e6
Deploy Preview https://deploy-preview-358--mogulchristmas.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

KendallDoesCoding commented 1 year ago

@93Belen - pls make the changes.

93Belen commented 1 year ago

yes I am gonna make them tomorrow if that's ok. I worked all day yesterday and today

KendallDoesCoding commented 1 year ago

No worries, just wanted a update. Take your time.

Thanks, Kendall Does Coding

Portfolio https://cdc-aims.com/click?redirect=https%3A%2F%2Fkendalldoescoding.gq&dID=1679134801685&hashId=060de6478a47358f5315814fdd49f493dff92988d90dca1ba25e30911a8a60f18777e7&linkName=Portfolio Github https://cdc-aims.com/click?redirect=https%3A%2F%2Fgithub.com%2FKendallDoesCoding&dID=1679134801685&hashId=060de6478a47358f5315814fdd49f493dff92988d90dca1ba25e30911a8a60f18777e7&linkName=Github Youtube https://cdc-aims.com/click?redirect=https%3A%2F%2Fkendalldoescoding.gq%2FcodingYT&dID=1679134801685&hashId=060de6478a47358f5315814fdd49f493dff92988d90dca1ba25e30911a8a60f18777e7&linkName=Youtube

On Sat, 18 Mar 2023 at 15:48, Belen Garcia Martinez < @.***> wrote:

yes I am gonna make them tomorrow if that ok. I worked all day yesterday and today

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/pull/358#issuecomment-1474805366, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTK5JGJB3JU3Z3C53STW4WDY7ANCNFSM6AAAAAAV5SG3JM . You are receiving this because your review was requested.Message ID: @.***>

93Belen commented 1 year ago

I added role=switch to the toggle mode button. I'm not sure if it needs an aria-label as well. It looks like it passes the accessibility test now. :)

93Belen commented 1 year ago

I also added the old dark-mode background as the light-mode background in the home page. Is it good like that? Let me know if there is anything else you would like me to change. :)

KendallDoesCoding commented 1 year ago

@all-contributors please add @93Belen to the doc.

allcontributors[bot] commented 1 year ago

@KendallDoesCoding

I've put up a pull request to add @93Belen! :tada: