Added artist page, FIXES #361 - Githubissues

KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.

https://kendalldoescoding.tech/mogulchristmas

Creative Commons Zero v1.0 Universal

23 stars 62 forks source link

Added artist page, FIXES #361 #362

Closed abhinav2712 closed 11 months ago

abhinav2712 commented 1 year ago

🛠️ Fixes Issue

Fixes #361

Related Issue/Addition to code

Adding Artist Page

👨‍💻 Changes proposed

Added an artist page in the nav item
Included 10 artists popular during Christmas
Hover enabled for more info regarding each artists

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

✔️ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

In future, It would be better to make a seperate database for every data present in this website

📷 Screenshots

New Feature:

netlify[bot] commented 1 year ago

Deploy Preview for mogulchristmas ready!

Name	Link
Latest commit	72283e3146bdbfed23579cc52c2f3dee39c3b4be
Latest deploy log	https://app.netlify.com/sites/mogulchristmas/deploys/6517204b1656920008742f06
Deploy Preview	https://deploy-preview-362--mogulchristmas.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

KendallDoesCoding commented 1 year ago

@abhinav2712 any update?

abhinav2712 commented 1 year ago

@abhinav2712 any update?

I may need some more time for this, just got into some other things, but will fix in coming time

KendallDoesCoding commented 1 year ago

Sure, take your time!

Thanks, Kendall Does Coding

Portfolio https://cdc-aims.com/click?redirect=https%3A%2F%2Fkendalldoescoding.gq&dID=1679807954569&hashId=060de6478a47358f5315814fdd49f493dff92988d90dca1ba25e30911a8a60f18777e7&linkName=Portfolio Github https://cdc-aims.com/click?redirect=https%3A%2F%2Fgithub.com%2FKendallDoesCoding&dID=1679807954569&hashId=060de6478a47358f5315814fdd49f493dff92988d90dca1ba25e30911a8a60f18777e7&linkName=Github Youtube https://cdc-aims.com/click?redirect=https%3A%2F%2Fkendalldoescoding.gq%2FcodingYT&dID=1679807954569&hashId=060de6478a47358f5315814fdd49f493dff92988d90dca1ba25e30911a8a60f18777e7&linkName=Youtube

On Sat, 25 Mar 2023 at 20:25, Abhinav Kumar @.***> wrote:

@abhinav2712 https://github.com/abhinav2712 any update?

I may need some more time for this, just got into some other things, but will fix in coming time

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/pull/362#issuecomment-1483844139, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTPOT3TUYWJAZVJV73DW54BPJANCNFSM6AAAAAAWG2UGM4 . You are receiving this because your review was requested.Message ID: @.***>

KendallDoesCoding commented 1 year ago

@abhinav2712 - any update?

KendallDoesCoding commented 1 year ago

@abhinav2712 - any update or should I close the PR?

KendallDoesCoding commented 1 year ago

@abhinav2712 why?

abhinav2712 commented 1 year ago

@KendallDoesCoding Man, Have a lot of other commitments, didnt want to hold this PR, you can do one thing to add this in issue s FEAT REQUEST, or shall I do it?

KendallDoesCoding commented 1 year ago

@KendallDoesCoding Man, Have a lot of other commitments, didnt want to hold this PR, you can do one thing to add this in issue s FEAT REQUEST, or shall I do it?

I'll reopen PR but I or someone else will work on it. I don't want to stress you out.