KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

wrote comments for some of HTML & JS codes #364

Closed harisdev-netizen closed 1 year ago

harisdev-netizen commented 1 year ago

🛠️ Fixes Issue

Related Issue/Addition to code

👨‍💻 Changes proposed

Type of change

✔️ Check List (Check all the applicable boxes)

📄 Note to reviewers

📷 Screenshots

Original Updated
** original screenshot updated screenshot
netlify[bot] commented 1 year ago

Deploy Preview for mogulchristmas ready!

Name Link
Latest commit b423123611f0c0092627351a49582702fbb2b5e9
Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/6431b845a73b760008ff8680
Deploy Preview https://deploy-preview-364--mogulchristmas.netlify.app/ludsocials/podcasts
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

harisdev-netizen commented 1 year ago

Merge the branch when feasible so then I can close the PR

KendallDoesCoding commented 1 year ago

Merge the branch when feasible so then I can close the PR

What do you mean? You said there is more to add to this PR above?

will complete the rest

harisdev-netizen commented 1 year ago

Oh sorry! Yeah yeah. I'm sorry for the inconvenience.

harisdev-netizen commented 1 year ago

I've almost finished the issue. Please review the code, and please add me to the project's list of contributors. For comments, I'll also look through additional files.

KendallDoesCoding commented 1 year ago

@harisdev-netizen . I forgot about the credits thing. Many people may be missing. Let me add them too. Thanks for reminding.

harisdev-netizen commented 1 year ago

Don't edit credits/index.html. it may cause some issues.

Okay got it.

harisdev-netizen commented 1 year ago

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

KendallDoesCoding commented 1 year ago

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

I don't think you've done index.html and css files.

harisdev-netizen commented 1 year ago

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

I don't think you've done index.html and css files.

Okay got it. I'm on it.

harisdev-netizen commented 1 year ago

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

I don't think you've done index.html and css files.

And apart from index.html and css files all the rest is great right?

KendallDoesCoding commented 1 year ago

@KendallDoesCoding can you confirm if I have covered all the project directories. If there's any left do tell. Thank you!

I don't think you've done index.html and css files.

And apart from index.html and css files all the rest is great right?

Yup.

KendallDoesCoding commented 1 year ago

Thanks for your contribution @harisdev-netizen

harisdev-netizen commented 1 year ago

No problem @KendallDoesCoding, I am really enjoying contributing to open-source.

harisdev-netizen commented 1 year ago

I hope you have added me to contributors list.

KendallDoesCoding commented 1 year ago

@harisdev-netizen - adding ur pfp now, will add ur contribution (pr) later.

KendallDoesCoding commented 1 year ago

@all-contributors please add @harisdev-netizen to the doc.

allcontributors[bot] commented 1 year ago

@KendallDoesCoding

I've put up a pull request to add @harisdev-netizen! :tada:

KendallDoesCoding commented 1 year ago

Kindly review the code and merge.

already merged bro