search

KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

[FEATURE REQUEST] -No Hand Cursor on Dark and Light Mode Button #394

Open mnik7044 opened 1 year ago

mnik7044 commented 1 year ago

Is your feature request related to a problem? Please describe. When hovering over the dark and light mode button on the website, the cursor does not change to a hand cursor, which may confuse some users who expect clickable elements to have a hand cursor. This issue is present on all pages of the website.

Describe the solution you'd like To fix this issue, you could add a CSS rule to change the cursor to a hand when hovering over the button. For example:

Why do you think we should add this feature? How will it be useful for the project? User experience: Adding a hand cursor to clickable elements is a common convention in web design, and it helps users understand that a particular element is interactive. Without a hand cursor on the dark and light mode button, users may not realize that it is clickable, which could result in a poor user experience.

Consistency: If the website uses a hand cursor for other clickable elements, such as links or buttons, it would be consistent with web design conventions to also use a hand cursor for the dark and light mode button. This would create a more unified and cohesive user experience.

mnik7044 commented 1 year ago

Hey @KendallDoesCoding I think I can fix this issue please assign it to me.

KendallDoesCoding commented 1 year ago

Is your feature request related to a problem? Please describe. When hovering over the dark and light mode button on the website, the cursor does not change to a hand cursor, which may confuse some users who expect clickable elements to have a hand cursor. This issue is present on all pages of the website.

Describe the solution you'd like To fix this issue, you could add a CSS rule to change the cursor to a hand when hovering over the button. For example:

Why do you think we should add this feature? How will it be useful for the project? User experience: Adding a hand cursor to clickable elements is a common convention in web design, and it helps users understand that a particular element is interactive. Without a hand cursor on the dark and light mode button, users may not realize that it is clickable, which could result in a poor user experience.

Consistency: If the website uses a hand cursor for other clickable elements, such as links or buttons, it would be consistent with web design conventions to also use a hand cursor for the dark and light mode button. This would create a more unified and cohesive user experience.

@mnik7044 - thanks for bringing this to my notice. Please work on this.

mnik7044 commented 1 year ago

Hey @KendallDoesCoding I am facing some issue in getting the dark/light button in the code can you help me on that?

KendallDoesCoding commented 1 year ago

Hey @KendallDoesCoding I am facing some issue in getting the dark/light button in the code can you help me on that?

it should be in index.js

mnik7044 commented 1 year ago

Ya looked for it, the structure of code is quite different from what I have worked with before.

mnik7044 commented 1 year ago

But let me try.

KendallDoesCoding commented 1 year ago

Hey @KendallDoesCoding I am facing some issue in getting the dark/light button in the code can you help me on that?

it should be in index.js

Yeah. We have to format code slightly better.

KendallDoesCoding commented 1 year ago

@mnik7044 - still can't seem to figure it out?

mnik7044 commented 1 year ago

No was not able to figure it out plus I am busy these days with my end sem going on, will actively contribute after 9th June, I have a lot in mind for this website.

mnik7044 commented 1 year ago

Do you have a discord or slack for this website @KendallDoesCoding ?

KendallDoesCoding commented 1 year ago

No was not able to figure it out plus I am busy these days with my end sem going on, will actively contribute after 9th June, I have a lot in mind for this website.

Ok. All the best with your end sem!

KendallDoesCoding commented 1 year ago

Do you have a discord or slack for this website @KendallDoesCoding ?

I have discord, you can reach me on Kendall#9903, what's your discord username?

mnik7044 commented 1 year ago

Mine is GodNik#1720

mnik7044 commented 1 year ago

Screenshot_2023-06-07-01-25-20-51_572064f74bd5f9fa804b05334aa4f912.jpg

Got this

KendallDoesCoding commented 11 months ago

No was not able to figure it out plus I am busy these days with my end sem going on, will actively contribute after 9th June, I have a lot in mind for this website.

Hey. Are you working on this @mnik7044 ?

KendallDoesCoding commented 11 months ago

Mine is GodNik#1720

sent a friend req

KendallDoesCoding commented 9 months ago

Hi @mnik7044 - Are you working on this?

Michael-Obele commented 5 months ago

Hey, @KendallDoesCoding, I can help with this issue if it's okay.