search

KendallDoesCoding / mogul-christmas

Ludwig Ahgren made a Christmas Album in 2020. I just thought of a project cause I was bored where you can play all the songs by a click of a button which you can already do from his timestamps but what makes it special is that it has lyrics of those songs too and a bunch of other features.
https://kendalldoescoding.tech/mogulchristmas
Creative Commons Zero v1.0 Universal
23 stars 62 forks source link

fixed the issue #407 #409

Closed Mumtaz12 closed 11 months ago

Mumtaz12 commented 11 months ago

🛠️ Fixes

Fixes #407

Related Issue/Addition to code

👨‍💻 Changes proposed

Type of change

✔️ Check List (Check all the applicable boxes)

📄 Note to reviewers

📷 Screenshots

Original Updated
** original screenshot updated screenshot

image

netlify[bot] commented 11 months ago

Deploy Preview for mogulchristmas ready!

Name Link
Latest commit 88db2f8ede09b979621eca54870891d06a0fcf3a
Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/6518ed10d6bf6100088e4f0d
Deploy Preview https://deploy-preview-409--mogulchristmas.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Mumtaz12 commented 11 months ago

Yes i will try again

On Sun, 1 Oct, 2023, 12:22 pm Kendall, @.***> wrote:

@.**** commented on this pull request.

Better than what it was, but can be improved.

[image: image] https://user-images.githubusercontent.com/84712013/271813092-988d9b42-3846-4e67-805d-d20bdda85a39.png

-

After "of" send "the" holiday season to the next line

The information is cutting, so can it be sent to the next line?

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/pull/409#pullrequestreview-1651846714, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ6KKERVSNW5MQQ3KR4CB3TX5EHJHANCNFSM6AAAAAA5N7QLO4 . You are receiving this because you authored the thread.Message ID: @.***>

Mumtaz12 commented 11 months ago

Review this code

Mumtaz12 commented 11 months ago

Review this code

KendallDoesCoding commented 11 months ago

@Mumtaz12 - thanks for your contribution!

Mumtaz12 commented 11 months ago

Its my pleasure

On Sun, 1 Oct, 2023, 5:39 pm Kendall, @.***> wrote:

@Mumtaz12 https://github.com/Mumtaz12 - thanks for your contribution!

— Reply to this email directly, view it on GitHub https://github.com/KendallDoesCoding/mogul-christmas/pull/409#issuecomment-1742060666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ6KKEUXA5BSQABIWGKGPVTX5FMP5ANCNFSM6AAAAAA5N7QLO4 . You are receiving this because you were mentioned.Message ID: @.***>