Kenix3 / libultraship

Porting games to the PC
MIT License
90 stars 64 forks source link

Fix gfx debugger with branch calls #570

Closed Archez closed 1 week ago

Archez commented 1 week ago

In #503 I fixed an actual issue with DL Branch causing infinite render loops. In that commit I also changed the argument passed into g_exec_stack.branch() which ended up breaking the gfx debugger. After digging into it, the argument passed into this function should be specifically the caller command instruction. Before it was sometimes correct, sometimes not. Now all instances will receive the correct called instruction.

I also added a missing g_exec_stack.branch for BRANCH_Z instructions.

Also increased the line buffer size in the gfx debugger to 512 to account for the rare commands that are really long (usually SetOtherMode)