Open apocalyptech opened 7 years ago
Hey, thank you for taking interest in the project and sorry for such a late response!
Now, onto the point :-]. I have not looked at the code yet, but I'll comment on the changes you described and how I think about them.
pacmixer
wouldn't work fine on them anyway and I don't like them visually :-).Def.
thing actually looks nice. I was kinda opposed at first, but it is more clear than a green/red block. Also takes less space, which is good. What I'd probably change is to move it above the name. Names, IMHO, act as a nice "line" that separates controls from the bottom status.o
binding, well, doesn't hurt, I guess ;-).FYI: The ongoing development of pacmixer
is kinda on hold now. That's because I'm trying to get out of the Objective-C fiasco, so I'm working on a little "framework" that will help me make this move, make implementing and controlling widgets easier and make everything more configurable (like colours, hiding/showing things, layouting, etc.). This will probably take some time, as I unfortunately don't have much of it to work on this...
No worries! Only so many hours in the day, etc.
I shall comment on a couple of your comments!
Anyway, no worries re: development! I've got a long list of personal projects on hold, so I get it. I'll look over this stuff again more thoroughly when I'm back, though!
Thanks, CJ
These are a whole bunch of tweaks to how pacmixer's TUI looks; mostly it's just layout/coloring changes, though I've also added in a new key (to toggle the options selections), and fixed a bug. I'm sure that much of this is down to personal preference, re: the layout, so if you like some of these but not all, I'd be happy to pull it apart a bit and get a smaller pull request together.
Anyway, here's what I've added to the project's changelog:
o
keybinding to toggle display of control options.Most of what I changed is apparent from a simple screenshot, so here's how it looks without the options dialogs showing:
... and here it is with the options dialogs:
As I say, personally I like how my tweaked version looks (and it's closer to how alsamixer looks), but I'd certainly understand if there's lots of bits in here that you don't actually want to merge.
Thanks for the app, btw! I'd always felt that not having an alsamixeralike for PulseAudio was one of its biggest weaknesses, so I was thrilled to stumble upon this.