Kennethsim2000 / pe

0 stars 0 forks source link

Allows phone number to contain more than 8 digits #3

Open Kennethsim2000 opened 2 years ago

Kennethsim2000 commented 2 years ago

add user n/Jenny Brown p/123456789 e/foo@gmail.com

image.png

soc-se-bot commented 2 years ago

Team's Response

Regarding our decisions on the constraints for phone numbers:

We have decided that having more lax restrictions on phone numbers would be a better design choice. This accommodates users with longer international phone numbers (and avoids the problem of overzealous input validation).

We also decided to maintain the original restriction of at least 3 digits, because there are things such as SMS short codes and N11 codes which can be used for whatever reason by the librarian.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]