search

Kennox / rscc

Remote Support Control Center
8 stars 3 forks source link

can be reset to defaults, Stun servers can be edited #190

Closed pwigger closed 7 years ago

pwigger commented 7 years ago

Settings are being reset in the model: user settings are not stored! maybe a task for jan to read and write it from an to the xml

rmosimann commented 7 years ago

I was so free to add "Saving" and "loading" of those user prefs. Still missing the StunServers.

rmosimann commented 7 years ago

@pwigger What about limiting to 4 STUN-Servers and make StringProperties and TextFields for them? in the actual form it is not possible to add a new one, but 4 should be enough. What do you think?

pwigger commented 7 years ago

kind of looks nicer if you can add unlimited... i adjusted the form and added 2 buttons to add and remove servers. should work that way i think..

pwigger commented 7 years ago

btw...Chloe misses some comments in the model ;)

rmosimann commented 7 years ago

Chloe is happy again. And STUNServers are also saved an loaded. Proper implementation of loading DEFAULT is still missing.

pwigger commented 7 years ago

What do you mean by proper? .. cant we just add readonly Values to the xml file and load those once you click default?

rmosimann commented 7 years ago

That sounds good to me.

martinfrancois commented 7 years ago

Since there were a lot of things and it would've been too complicated to explain it all, I fixed all of the bugs as I see it. You can now save and load the default settings, as well I implemented that the defaults button doesn't close the dialog and pressing the defaults button will not automatically save the defaults, only if you press "apply". Since there have been quite a big amount of changes by me, I'd be glad if someone could have a look at it.

pwigger commented 7 years ago

Fixed some checkstyle errors. To the load of constants we have now in the model... wouldnt it be nicer if we have those constants in the xml? instead of hardcoded defaultvalues in the code? like a xml kind of
<settings>
`

`
` `
` `
martinfrancois commented 7 years ago

It may be nicer, but would require us to write a new class and port some methods of the supporthelper over so it works with the settings - I think for now it's best to focus on other things, since it works.

martinfrancois commented 7 years ago

added TODO for @pwigger's proposal at issue #196