Kennyc1012 / BottomSheetMenu

BottomSheetMenu style dialogs for Android
Apache License 2.0
887 stars 99 forks source link

supportsRtl #31

Closed miladna7 closed 8 years ago

miladna7 commented 8 years ago

Hello dear. is it possible for u to remove or change this line supportsRtl="true" (here) from ur project? i do not want to support RTL but i cant set it to false, because ur library set it true and for result android studio give me this:

Error:Execution failed for task ':app:processDebugManifest'.
> Manifest merger failed : Attribute application@supportsRtl value=(false) from AndroidManifest.xml:21:9-36
    is also present at [com.github.Kennyc1012:BottomSheet:2.1.1] AndroidManifest.xml:11:18-44 value=(true).
    Suggestion: add 'tools:replace="android:supportsRtl"' to <application> element at AndroidManifest.xml:15:5-62:19 to override. 
Kennyc1012 commented 8 years ago

Did you use the tools:replace="android:supportsRtl" like stated in the output? That should fix the issue.

It should look something like

<application 
tools:replace="android:supportsRtl" ..
miladna7 commented 8 years ago

Yes indeed. but it give me:

Error:Execution failed for task ':app:processDebugManifest'.
> Manifest merger failed with multiple errors, see logs

and in the log :


6:54:15 PM Executing tasks: [:app:assembleDebug]
6:54:16 PM Gradle build finished with 1 error(s) in 1s 288ms
Kennyc1012 commented 8 years ago

I got it working with the sample app

 <application
        android:allowBackup="true"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:theme="@style/AppTheme"
        android:supportsRtl="false"
        xmlns:tools="http://schemas.android.com/tools"
        tools:replace="android:supportsRtl">
        <activity
            android:name=".MainActivity"
            android:label="@string/app_name" >
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />

                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>
        </activity>
    </application>

Can you paste your application tag?

miladna7 commented 8 years ago

So clearly the error are coming from my app. i keep digging. Thanks for such a quick response .

  <application
        android:name=".pushService"
        android:allowBackup="true"
        android:icon="@drawable/logo_green_croped"
        android:label="@string/app_name"
        tools:replace="android:supportsRTL"
        android:supportsRtl="false"
        android:theme="@style/AppTheme">
Kennyc1012 commented 8 years ago
tools:replace="android:supportsRTL"

should be

tools:replace="android:supportsRtl"

Notice the 'l' and 't' are not capitalized in 'Rtl'

miladna7 commented 8 years ago

thank u dear. sorry to take ur time.