Kennyc1012 / BottomSheetMenu

BottomSheetMenu style dialogs for Android
Apache License 2.0
887 stars 99 forks source link

Improvements #48

Closed MFlisar closed 6 years ago

MFlisar commented 6 years ago

I made following changes:

Only last point needs explanations. I need to dynamically remove/disable items from an inflated menu, so I needed a listener for it. This is probably useful for others as well. Additionally I use Iconics in my projects and I've written a custom menu inflator for this library, my changes allow to use any menu inflater implementation.

Kennyc1012 commented 6 years ago

I rather not expose menu inflating outside of the library, is the solution in #9 not sufficient? You can supply your own instance of a Menu to the build, which you can inflate yourself.

MFlisar commented 6 years ago

You're right, this works as well (did not see this though).

I would still prefer the builder to support this, as I could use builder like chaining like this, but it's ok for me this way as well.