search

Kennyc1012 / BottomSheetMenu

BottomSheetMenu style dialogs for Android
Apache License 2.0
887 stars 99 forks source link

Make QUERY_ALL_PACKAGES permission not mandatory #72

Closed unbiaseduser closed 1 year ago

unbiaseduser commented 1 year ago

Hello. I don't know if the library is still maintained, but here I go. You know what they say: Insanity is doing the same thing many times and expecting different results... or something like that. I'm insane, that's why I'm here. Anyways, I resolved #70. Google has a way of expressing permission requirements in individual methods without declaring them in the manifest (and forcing the permission into users' apps) which I used. I don't expect anything much, considering that the last commit is almost a year ago, but one has to have hope in life. Thank you for reading if you're still here.

Kennyc1012 commented 1 year ago

Thank you for the PR @unbiaseduser .Your second commit will cause some issues as the added constant Manifest.permission.QUERY_ALL_PACKAGES is only available on Android 11+. I will clean up the permission however.

My purposed solution is to remove the permission as well as mark the createShareBottomSheet methods as deprecated. They will be removed in a future release.

unbiaseduser commented 1 year ago

OK, thanks for your input. About the potential issues you mentioned, I did test the sample app with my branch on a Android 7 emulator and a Android 10 phone and got no problems (well, if I got problems, I wouldn't make a PR in the first place). But your solution works too, I have no objections. 🙂