Keno / REPL.jl

Pure-julia REPL implementation
Other
3 stars 4 forks source link

Split completion functionality into a separate package. #4

Closed stevengj closed 11 years ago

stevengj commented 11 years ago

I'm getting Warning: could not import Readline.history_search into REPL when I launch the Julia IPython kernel, which uses REPL.jl for tab completions. The package shouldn't assume that it is actually being used for a REPL or that it is in charge if the history.

Or better yet the completion functionality should be split off into a separate package (so that we don't pull in Terminal and other irrelevant packages REPL needs just to get tab completion, as well as to speed startup time).

cc: @StefanKarpinski

stevengj commented 11 years ago

Or should the completion functionality go into Base?

I'm a little confused about how this REPL package relates to the REPL functionality in Base.

StefanKarpinski commented 11 years ago

I have no idea – this is @loladiro's stuff.

Keno commented 11 years ago

I plan to eventually replace the REPL implementation in Base with this one - probably in the 0.3, but I can certainly split the completion functionality out before then.

stevengj commented 11 years ago

Maybe just merge the completion functionality back into Base for now, then?

Keno commented 11 years ago

I'd rather not since it's still very much in flux, but if people feel strongly about this, I can be convinced.

stevengj commented 11 years ago

A separate package (in METADATA) would be fine if you think the completion functions aren't ready for Base.

I'm hoping we can clean up the IJulia packaging this week now that it's mostly functional, and the first task is to clean up the dependencies.

stevengj commented 11 years ago

All we need are complete_symbol(s) and completions(s,pos); just put them in a module JuliaCompletion or similar and export completions.

I would do it myself, but probably it should live in github/loladiro and you will want to update the REPL package at the same time.

stevengj commented 11 years ago

Awesome, thanks!