search

Keno / SIUnits.jl

Efficient unit-checked computation
Other
70 stars 26 forks source link

Make SIUnits compatible with Gadfly #66

Closed mdavezac closed 9 years ago

mdavezac commented 9 years ago

The point is to be able to plot quantities with units:

using Gadfly
using SIUnits
using SIUnits.Shorthand
x = [1:16]m
plot(x=x, y=x.*x)

The example above issues warnings about function clashes with a * in Compose and isless in DualNumbers, both used by Gadfly.

This pull-request corrects both issues by declaring the functions with more specific types.

ivarne commented 9 years ago

There is no need to open a new Pull Request (https://github.com/Keno/SIUnits.jl/pull/67) in order to update the content, or sets of commits. Just click the edit button on Github, or push new commtis to your branch.

It's not a huge deal on a low traffic repository like SIUnits though.

mdavezac commented 9 years ago

Fair enough. It just felt a bit cleaner.