search

Keno / SIUnits.jl

Efficient unit-checked computation
Other
70 stars 26 forks source link

Take advantage of UnitTuple to store type info #78

Open drewkett opened 8 years ago

drewkett commented 8 years ago

I tried recreating this package as an exercise to understand the type system better. I found that using UnitTuple directly in SIUnit and SIQuantity simplified things quite a bit. I updated this package to work that way as well. Its a big change, but the tests are passing for me, so hopefully I fixed everything that needs to be fixed. I have a few other changes that simplify a few things, but this was the biggest change.

Keno commented 8 years ago

Indeed, this package was written for 0.2, where that wan't possible yet. In particular #5, the earliest still open issue in this package.

drewkett commented 8 years ago

Oh, I didn't see that. Yea, that makes sense. Do you still want to support 0.2 with this package, or could something like this be merged?

Keno commented 8 years ago

No, 0.2 is obsolete at this point On Nov 18, 2015 1:47 PM, "Andrew Burkett" notifications@github.com wrote:

Oh, I didn't see that. Yea, that makes sense. Do you still want to support 0.2 with this package, or could something like this be merged?

— Reply to this email directly or view it on GitHub https://github.com/Keno/SIUnits.jl/pull/78#issuecomment-157818083.

drewkett commented 8 years ago

Ok. I noticed the latex output is broken on new version, and that the coverage tool is failing. Are you fine with change otherwise?