Closed Mart-Dan-Rossi closed 2 months ago
[sand] En la carta dice que en "enabled" el botón tiene que ser de un verde claro y en "disabled" un gris. En este momento, el botón es permanentemente amarillo. Lo que está cambiando por lo que veo es el color del rayo que está "greenyellow" o "darkgreen". El rayo está bien que se mantenga en amarillo.
Antes de comenzar la revisión comento que me parece que lo más correcto sería tener varios PRs para los cambios que introducís. Un PR debería abarcar una sola tarea, por más pequeña que sea. Eso facilita el seguimiento y la revisión de los cambios 😄
[rock] Al correr la aplicación en local por primera vez tuve la siguiente salida con algunos warnings. Esto no ocurría previamente con la versión en dev
.
yarn run v1.22.22
$ next dev
▲ Next.js 14.2.3
- Local: http://localhost:3000
- Environments: .env
✓ Starting...
✓ Ready in 2.3s
○ Compiling / ...
<w> [webpack.cache.PackFileCacheStrategy] Skipped not serializable cache item 'Compilation/modules|javascript/auto|/Users/eliascerdeira/git/kenrou/cheddar-ecosystem/node_modules/next/dist/build/webpack/loaders/next-flight-css-loader.js??ruleSet[1].rules[14].oneOf[7].use[0]!/Users/eliascerdeira/git/kenrou/cheddar-ecosystem/node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[14].oneOf[7].use[1]!/Users/eliascerdeira/git/kenrou/cheddar-ecosystem/node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[14].oneOf[7].use[2]!/Users/eliascerdeira/git/kenrou/cheddar-ecosystem/src/styles/BuyNFTSection.module.css|ssr': No serializer registered for Warning
<w> while serializing webpack/lib/cache/PackFileCacheStrategy.PackContentItems -> webpack/lib/NormalModule -> Array { 1 items } -> webpack/lib/ModuleWarning -> Warning
⚠ ./src/styles/BuyNFTSection.module.css.webpack[javascript/auto]!=!./node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[2]!./node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[3]!./src/styles/BuyNFTSection.module.css
Warning
(20:3) autoprefixer: start value has mixed support, consider using flex-start instead
Import trace for requested module:
./src/styles/BuyNFTSection.module.css.webpack[javascript/auto]!=!./node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[2]!./node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[3]!./src/styles/BuyNFTSection.module.css
./src/styles/BuyNFTSection.module.css
./src/components/ModalBuyNFT.tsx
./src/components/GameboardContainer.tsx
./src/app/page.tsx
./src/styles/BuyNFTSection.module.css
Warning
(20:3) autoprefixer: start value has mixed support, consider using flex-start instead
Import trace for requested module:
./src/styles/BuyNFTSection.module.css
./src/components/ModalBuyNFT.tsx
./src/components/GameboardContainer.tsx
./src/app/page.tsx
(node:16563) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
GET / 200 in 6056ms
<w> [webpack.cache.PackFileCacheStrategy] Skipped not serializable cache item 'Compilation/modules|/Users/eliascerdeira/git/kenrou/cheddar-ecosystem/node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[2]!/Users/eliascerdeira/git/kenrou/cheddar-ecosystem/node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[3]!/Users/eliascerdeira/git/kenrou/cheddar-ecosystem/src/styles/BuyNFTSection.module.css': No serializer registered for Warning
<w> while serializing webpack/lib/cache/PackFileCacheStrategy.PackContentItems -> webpack/lib/NormalModule -> Array { 1 items } -> webpack/lib/ModuleWarning -> Warning
⚠ ./src/styles/BuyNFTSection.module.css.webpack[javascript/auto]!=!./node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[2]!./node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[3]!./src/styles/BuyNFTSection.module.css
Warning
(20:3) autoprefixer: start value has mixed support, consider using flex-start instead
Import trace for requested module:
./src/styles/BuyNFTSection.module.css.webpack[javascript/auto]!=!./node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[2]!./node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[3]!./src/styles/BuyNFTSection.module.css
./src/styles/BuyNFTSection.module.css
./src/components/ModalBuyNFT.tsx
./src/components/GameboardContainer.tsx
./src/app/page.tsx
./src/styles/BuyNFTSection.module.css
Warning
(20:3) autoprefixer: start value has mixed support, consider using flex-start instead
Import trace for requested module:
./src/styles/BuyNFTSection.module.css
./src/components/ModalBuyNFT.tsx
./src/components/GameboardContainer.tsx
./src/app/page.tsx
⚠ ./src/styles/BuyNFTSection.module.css.webpack[javascript/auto]!=!./node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[2]!./node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[3]!./src/styles/BuyNFTSection.module.css
Warning
(20:3) autoprefixer: start value has mixed support, consider using flex-start instead
Import trace for requested module:
./src/styles/BuyNFTSection.module.css.webpack[javascript/auto]!=!./node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[2]!./node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[7].use[3]!./src/styles/BuyNFTSection.module.css
./src/styles/BuyNFTSection.module.css
./src/components/ModalBuyNFT.tsx
./src/components/GameboardContainer.tsx
./src/app/page.tsx
./src/styles/BuyNFTSection.module.css
Warning
(20:3) autoprefixer: start value has mixed support, consider using flex-start instead
Import trace for requested module:
./src/styles/BuyNFTSection.module.css
./src/components/ModalBuyNFT.tsx
./src/components/GameboardContainer.tsx
./src/app/page.tsx
[rock] Como mencionó Dani, el botón se ve siempre amarillo con el rayo en color verde en este caso. El código entonces no coincide con lo esperado.
[validar] El nuevo slider se comporta correctamente según lo descrito. Se observa en amarillo cuando está en Cheddar y en gris cuando está en Near.
[rock] Según tu descripción yo debería ver el rayo en gris porque no tengo Cheddar, sin embargo lo veo verde. Por lo tanto, no se corresponde el comportamiento visto con lo esperado.
Cambios de estilos del botón de power up hechos. También se agregó que si el usuario ya tiene comprado un NFT no se abre el modal para comprar NFT.
Multiple jobs done: -Change the selection of the tokens for a Switch/slider
-Since power up button does nothing on click, fuse it with the buy button. On click it should open the buy modal or the wallet selector depending if the user is connected or disconnected
-Button should be "enabled" when user has at least 1 cheddar NFT and "disabled" when has none. On enabled it should be some kind of light green. On disabled, some grey. This is up to debate if considered bad options. (I used the colors "darkgreen" and "greenyellow" (If you want to change it you can easily find it looking for "powerUpActive" & "powerUpNotActive")).