search

Kenshin9977 / video-dl

A GUI for yt-dlp that aims to simplify its usage.
MIT License
32 stars 7 forks source link

Add playlist start/end and playlist items #11

Closed KnifeOnlyI closed 2 years ago

KnifeOnlyI commented 2 years ago

PR brings playlist download parameters feature :

The GUI is not perfect, it will not be clear for users (especially in priority order). But this can be improved in a future update.

If the playlist checbox is not ticked, the program always download only one video (the first video for a playlist, and the video for a video link). If the playlist is ticked, the program download (in priority) :

  1. The specified items list
  2. OR The specified start / end videos
  3. OR The video (if the link is a video link)

News : If the link is a video link with playlist (e.g : here), the program download the playlist (items or start/end) if the playlist checkbox is ticked.

Kenshin9977 commented 2 years ago

You took a pretty cumbersome approach as yt-dlp already checks if the playlist-item option is valid or not. You should let yt-dlp check the correctness of the value as there are many edge cases you don't currently handle (incorrect list, letters within the indices...). In the GUI we should only have an "Indices" field. Remove the "Start" and "End" fields. We could set a default value when the fields is disabled in order to have some sort of example which would be removed as soon as the Indices box is ticked. You also could disable the "Start" and "End" boxes that allow us to input the timecodes when playlist is ticked as I don't really see any reason to use those when downloading a playlist.

KnifeOnlyI commented 2 years ago

I push a new commit to update the new feature, according to your remarks.

I also fix label size for begin/end timers for deutsch translation.

Kenshin9977 commented 2 years ago

The default value isn't erased when we tick Indices