search

Kentico / KInspector

KInspector is an application for analyzing health, performance and security of your Kentico solution.
MIT License
56 stars 63 forks source link

Ensure compatibility with Kentico 11 #164

Closed petrsvihlik closed 6 years ago

petrsvihlik commented 6 years ago

Similarly to #123

Perhaps @ileshmistry might be interested to help out again? :)

ileshmistry commented 6 years ago

@petrsvihlik Sure I can help out on this one

sultanwork77 commented 6 years ago

Is this up for Kentico-11 now?

petrsvihlik commented 6 years ago

@sultanwork77 this item hasn't been implemented yet. would you be interested in helping out?

sultanwork77 commented 6 years ago

@petrsvihlik I have done changes internally by cloning master and creating an internal branch. I have added support for version 11 where ever the support for 10 was present and ignored where there was not. Now problem is that am unable to push that branch. am getting errors as Error encountered while pushing branch to the remote repository: Git failed with a fatal error. unable to access 'https://github.com/Kentico/KInspector.git/': The requested URL returned error: 403

petrsvihlik commented 6 years ago

@sultanwork77 you need to fork KInspector under your account, clone it locally, make changes, push the changes to a branch in your fork and then submit a pull request. see the video here: https://www.youtube.com/watch?v=ixGakcfITe8

sultanwork77 commented 6 years ago

@petrsvihlik Done as suggested by you and raised a pull request Committing support version for Kentico-11 #165

Enngage commented 6 years ago

I think we should make this a higher priority because its only a matter of time when we will really need this for K11. Actually, I'm writing here because I already do:)

ChristopherJennings commented 6 years ago

Forgot to update this issue. This was addressed in PR #165, which has been merged into master. There is one outstanding issue #167, that should be addressed, but the main functionality is there. Closing this issue.