search

KentonWhite / ProjectTemplate

A template utility for R projects that provides a skeletal project.
http://projecttemplate.net
GNU General Public License v3.0
622 stars 159 forks source link

Make sql.reader more flexible for odbcDriverConnect #144

Open tomschloss opened 8 years ago

tomschloss commented 8 years ago

This is more of a selfish feature request which I'm happy to work on, but wondering if you have any concerns with the idea.

The current sql.reader for odbc requires very particular inputs. odbcDriverConnect accepts a whole bunch of other inputs by allowing "a more flexible specification via a connection string". My idea is for sql.reader to be a little more flexible with inputs to make use of this flexibility. Basically, instead of looking only at specified settings (dsn; user; password; dbname) it would pull through all the settings specified.

KentonWhite commented 8 years ago

I like the idea. I've been bit a few times with sql.reader not accepting all of the inputs and have made piecemeal changes when they come up (e.g. passing a port to postgres). Really appreciate your offer to look into a more flexible specification. Please be considerate of others and use sensible defaults when a setting is missing.

tomschloss commented 8 years ago

Hopefully this is on point. Let me know either way. I think there is some possibility for extending this to the other db connection types.

KentonWhite commented 6 years ago

Bumping this as it is a good idea. Anyone with expertise that can work on this?