search

KentonWhite / ProjectTemplate

A template utility for R projects that provides a skeletal project.
http://projecttemplate.net
GNU General Public License v3.0
622 stars 159 forks source link

Clean exit for more functions when current directory is not valid Project template #163

Closed connectedblue closed 7 years ago

connectedblue commented 7 years ago

This PR proposes extending the feature in #157 to the following functions:

These will now exit cleanly with an error message if they are executed in a non ProjectTemplate directory.

In order to simplify the implementation, two helper functions are created: .stopifnotproject() and .stopifproject(). The load.project() and create.project() have been refactored to use these new functions.

These functions now issue a stop() rather than return(NULL) so the tests have been modified to account for the new behaviour.

Finally, since this function is used in a wide range of functions, the helpers have been moved away from the load.project.R to a new file called stopifnotproject.R for ease of reference.

connectedblue commented 7 years ago

Not sure why the travis tests all failed. They all work locally on my machine.

I'll try and force a re-run in case there's a problem with the travis tool

connectedblue commented 7 years ago

ok, there's something odd going on here. I'll close this PR and investigate further.

connectedblue commented 7 years ago

@KentonWhite This PR is ready for review now.

Sorry about all the closing and re-opening. I finally tracked down the problem with a missing function which I've now added back. What I can't explain though is how all my tests passed locally without this. I hate it when things can't be explained ....

Anyway, all seems fine now - this PR just extends the earlier functionality across a lot more functions.