Prune unused code - Githubissues

KentonWhite / ProjectTemplate

A template utility for R projects that provides a skeletal project.

http://projecttemplate.net

GNU General Public License v3.0

623 stars 159 forks source link

Prune unused code #181

Closed connectedblue closed 7 years ago

connectedblue commented 7 years ago

This PR proposes a small cleanup to two functions:

Remove unused function .get.template.tar.path() in create.project. This doesn't get called from anywhere and doesn't appear to be relevant for how templates are created. Perhaps it is a relic of how skeleton projects used to be created?
- Remove two commented out code chunks in load.project. Again, looks like a design decision taken in the past and not relevant now.

No user functionality changed as a result of this PR.

Hugovdberg commented 7 years ago

The .get.template.tar.path function is much like a basic version of the .get.template function I suggested in #179 ;-) but I don't see any problems in removing those lines of code.

connectedblue commented 7 years ago

Yes, that was what prompted me to raise this PR - my brain hurts when I try to link all these things in my head.

Hopefully this PR will reduce the cognitive burden for ProjectTemplate developers just a little :)