search

KentonWhite / ProjectTemplate

A template utility for R projects that provides a skeletal project.
http://projecttemplate.net
GNU General Public License v3.0
623 stars 159 forks source link

Issue #205 - Use tidy verse #207

Closed rsangole closed 7 years ago

rsangole commented 7 years ago

Changes full/global.dcf. Replaces packages with tidyverse. Reshape with reshape2.

Hugovdberg commented 7 years ago

The new commit looks reasonable. We do need to think about how we communicate we change to reshape2, since it isn't a 100% drop in replacement for reshape. migrate.project doesn't touch the configuration so that's no issue, but perhaps we can notify users via some other way. Also, @KentonWhite should the suggested packages in DESCRIPTION be updated as well, or are those only for packages used internally in ProjectTemplate?

rsangole commented 7 years ago

That's a good point. How is this type of communication typically handled for a package update?

KentonWhite commented 7 years ago

I convinced myself we don't need to worry. Legacy projects will be written to use the reshape package. In those projects they will have a global.dcf file with the reshape package not the reshape2 package. Only new projects will be created with the reshape2 package. By definition they do not have existing code and so nothing to break! If they want to use reshape with a new project they can manually change the config file.

I think it is fine to make a note of the change in the NEWS.md file.

rsangole commented 7 years ago

Perfect. I've put in reshape2 in the pull request.

Thoughts on also including forcats? It's something I use everyday, but not sure about you guys.