KentonWhite / ProjectTemplate

A template utility for R projects that provides a skeletal project.
http://projecttemplate.net
GNU General Public License v3.0
623 stars 159 forks source link

Checking fails with current dev version of RSQLite #228

Closed krlmlr closed 6 years ago

krlmlr commented 6 years ago

Report an Issue / Request a Feature

I'm submitting a (Check one with "x") :


Issue Severity Classification -

(Check one with "x") :

Expected Behavior

R CMD check succeeds with the dev version of RSQLite.

Current Behavior

Doesn't, fails with:

      Warnings: 0
      Skipped:  0
      ── 1. Failure: ignored data files are not loaded (@test-load.R#183)  ───────────
      `load.project(override.config = list(data_ignore = ""))` threw an error with unexpected message.
      Expected match: "file is encrypted or is not a database"
      Actual message: "file is not a database"

      ══ testthat results  ═══════════════════════════════════════════════════════════
      OK: 636 SKIPPED: 4 FAILED: 1
      1. Failure: ignored data files are not loaded (@test-load.R#183)

      Error: testthat unit tests failed
      In addition: Warning message:
      call dbDisconnect() when finished working with a connection
      Execution halted
Steps to Reproduce Behavior
Version Information

ProjectTemplate 0.8, r-dbi/RSQLite@b9df7dd

Possible Solution

Please refrain from checking (exact) wording for third-party error messages.

krlmlr commented 6 years ago

RSQLite has been updated on CRAN, checks for ProjectTemplate fail now.

KentonWhite commented 6 years ago

Fixed and being submitted to CRAN