fix pattern not intended for file extensions like .qs.hash

gisler commented 3 years ago

Types of change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (documentation etc)

Pull request checklist

[ ] Add functionality
[x] Add tests
[ ] Update documentation in man
[ ] Update website documentation

Proposed changes

When adding qs as a cache file format, I didn't notice that the pattern used in sub() within .cached.variables() is not suitable for file extensions like ".qs.hash". The proposed changes are supposed to fix this and to generally optimise said function. Furthermore, they also add a test checking if variable names are now assessed correctly from the cached file names.

KentonWhite commented 3 years ago

Thanks for this. I'm having trouble with the Travis checks. I'm going to add some empty commits to trigger a new build. Hopefully that works and I can merge this fix into the repo

gisler commented 3 years ago

@KentonWhite Hmm ... since Travis rather frequently seems to cause troubles: Have you looked into GitHub Actions yet? There are standard test workflows available for R packages. I just would have to look up the repo.

KentonWhite commented 3 years ago

@gisler thanks. It wasn’t a problem on the github end. Travis recently changed their account structures and my Travis account wasn’t set up correctly. All is good now.

KentonWhite / ProjectTemplate