Kentzo / ShortcutRecorder

The best control to record shortcuts on macOS, written in ObjC with Swift in mind

Other

575 stars 115 forks source link

Shortcut Recorder 3.2 #122

Closed Kentzo closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #122 into master will not change coverage by %. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   66.07%   66.07%           
=======================================
  Files          15       15           
  Lines        4752     4752           
=======================================
  Hits         3140     3140           
  Misses       1612     1612

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 631b609...631b609. Read the comment docs.

Kentzo commented 4 years ago

@lwouis would you do the honors and green-light the build?

lwouis commented 4 years ago

Hey @Kentzo! I don't know what kind of QA/testing you usually run before merging a PR.

I shipped AltTab with the head of issue-114 this week. I think you've added a few commits since then.

I can run AltTab locally pointing at develop and test manually maybe. Would that be useful? :)

Kentzo commented 4 years ago

Yup, that should be enough

lwouis commented 4 years ago

Hey @Kentzo! Sorry for the delay!

I just tested AltTab with ShortcutRecorder develop branch (on commit 631b609), and everything is working great!

Note: could you please keep the issue-114 branch open for a while after you merge this PR? This will give me some time buffer to point to the released version instead of the branch, and avoid breaking the build if I don't migrate straight away

Kentzo commented 4 years ago

Sure, I will keep it open till June 1st. After I delete it will be accessible for some time, thanks GitHub caching.