Closed legoktm closed 6 years ago
:exclamation: No coverage uploaded for pull request base (
master@16a79f7
). Click here to learn what that means. The diff coverage is85.71%
.
@@ Coverage Diff @@
## master #45 +/- ##
=========================================
Coverage ? 50.67%
=========================================
Files ? 1
Lines ? 148
Branches ? 29
=========================================
Hits ? 75
Misses ? 59
Partials ? 14
Impacted Files | Coverage Δ | |
---|---|---|
git_archive_all.py | 50.67% <85.71%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 16a79f7...2a34ad4. Read the comment docs.
Instead of implementing our own parsing and handling of
.gitattributes
, shell out to git'scheck-attr
command to take care of the parsing and processing for us.Notably, git handles unsetting properties properly.
Fixes #44.
The downside of shelling out is that in my testing it was 3x slower for MediaWiki, but the upside is that it cut down a ton custom code.