search

Kentzo / git-archive-all

A python script wrapper for git-archive that archives a git superproject and its submodules, if it has any. Takes into account .gitattributes
MIT License
372 stars 81 forks source link

Fixed fail of "git check-attr" file path #49

Closed Wohlstand closed 6 years ago

Wohlstand commented 6 years ago

When filename contains brackets or apostrophes:

Jonh's test.txt
Old test (check later).txt

the "git check-attr" command fails and stops the whole process

/bin/sh: 1: Syntax error: "(" unexpected

The fix is simple and easy - use quotes on file path.

codecov[bot] commented 6 years ago

Codecov Report

Merging #49 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #49   +/-   ##
====================================
  Coverage      50%   50%           
====================================
  Files           1     1           
  Lines         150   150           
  Branches       29    29           
====================================
  Hits           75    75           
  Misses         61    61           
  Partials       14    14
Impacted Files Coverage Δ
git_archive_all.py 50% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d899beb...1b6ef48. Read the comment docs.

Kentzo commented 6 years ago

Thank you for pointing to the problem.

Kentzo commented 6 years ago

Closed in favor of #50.