search

Kentzo / git-archive-all

A python script wrapper for git-archive that archives a git superproject and its submodules, if it has any. Takes into account .gitattributes
MIT License
372 stars 81 forks source link

Fix zip format recognition #52

Closed goriy closed 6 years ago

goriy commented 6 years ago

Changes introduced by commit dc84afd7f10b7a8eca7bc7637d87f147a1eb66e4 ("Fix tbz2 format was not recognized" - 20.09.2018) broke zip format recognintion.

File extension returned by os.path.splitext() is 'zip', not '.zip'

Before breaking changes extension checking code looked like "if output_format == 'zip':" (without dot)

codecov[bot] commented 6 years ago

Codecov Report

Merging #52 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   31.22%   31.22%           
=======================================
  Files           1        1           
  Lines         269      269           
  Branches       28       28           
=======================================
  Hits           84       84           
  Misses        171      171           
  Partials       14       14
Impacted Files Coverage Δ
git_archive_all.py 31.22% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96dbc1d...f19b099. Read the comment docs.

Kentzo commented 6 years ago

Thanks, that was a very unfortunate oversight.