Kentzo / git-archive-all

A python script wrapper for git-archive that archives a git superproject and its submodules, if it has any. Takes into account .gitattributes
MIT License
372 stars 81 forks source link

Tests failing with "ResourceWarning: unclosed file" when new test dependencies are used #90

Closed fgaz closed 1 year ago

fgaz commented 1 year ago

I'm packaging git-archive-all for NixOS, and I'm trying to update the test dependencies because the specified version are very old, but on almost all tests I'm getting ResourceWarning: unclosed file <_io.BufferedReader name='[...]/repo.tar'>.

All distributions that package git-archive-all currently disable tests because of this.

Removing filterwarnings = error also fixes the issue (we do this in the NixOS package), but then the warnings are ignored.

Kentzo commented 1 year ago

Should be address in master.