KenzieMac130 / ogre-procedural

Automatically exported from code.google.com/p/ogre-procedural
0 stars 0 forks source link

Wrong install paths for CMake files #63

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The current install target will, among other things which are correct, install 
these files to these locations:

-- Installing: /tmp/ogre-procedural/pkg/PROCEDURAL/cmake/FindOIS.cmake
-- Installing: /tmp/ogre-procedural/pkg/PROCEDURAL/cmake/FindOGRE.cmake
-- Installing: /tmp/ogre-procedural/pkg/PROCEDURAL/cmake/FindPROCEDURAL.cmake
-- Installing: /tmp/ogre-procedural/pkg/PROCEDURAL/cmake/FindPkgMacros.cmake
-- Installing: /tmp/ogre-procedural/pkg/PROCEDURAL/cmake/PreprocessorUtils.cmake
-- Installing: /tmp/ogre-procedural/pkg/PROCEDURAL/cmake/ProceduralMacros.cmake

This has multiple problems. First of all, you should really only install 
FindPROCEDURAL.cmake because installing any of the others would lead to 
duplicates as they are already installed by ogre.

Next, your install path is all wrong. CMake already has a convenient constant 
for you to always get its correct and respective install path (CMAKE_ROOT). Why 
not use it?

In conclusion, CMake/CMakeLists.txt should now only contain (and I mean *only*, 
as in nothing else):

install(FILES Packages/FindPROCEDURAL.cmake
    DESTINATION ${CMAKE_ROOT}/Modules)

and nothing else. If you really want me to I can make a patch but this should 
be enough to make all changes.

Original issue reported on code.google.com by svenst...@gmail.com on 24 Jul 2011 at 8:11

GoogleCodeExporter commented 8 years ago
I've got to make tests about it, but I'm not sure I want to install everything 
to Cmake directories (at least with Windows, cause the UAC would screw up 
everything)

Original comment by michael.broutin@gmail.com on 1 Aug 2011 at 9:03

GoogleCodeExporter commented 8 years ago

Original comment by michael.broutin@gmail.com on 24 Aug 2011 at 1:48

GoogleCodeExporter commented 8 years ago

Original comment by michael.broutin@gmail.com on 1 Sep 2011 at 8:37

GoogleCodeExporter commented 8 years ago
Did an hybrid form of the 2 : FindOgreProcedural.cmake is installed to cmake 
module path, and all other needed cmake files are copied to {sdk_path}/cmake

Original comment by michael.broutin@gmail.com on 25 Sep 2011 at 9:38