search

Kenzitron / protractor-jasmine2-html-reporter

HTML reporter for Jasmine2 and Protractor
32 stars 53 forks source link

screenshotsFolder doesn't work #24 #25

Closed s10mcow closed 7 years ago

s10mcow commented 8 years ago

The parent dir and the image source dir are being concat without the / to divide them

bitecoder commented 8 years ago

Can anyone merge this fix.

Laloutre42 commented 8 years ago

+1

ajoslin103 commented 8 years ago

a better fix would be to replace the + with a ,

screenshotPath = path.join(self.savePath + self.screenshotsFolder, spec.screenshot);

screenshotPath = path.join(self.savePath, self.screenshotsFolder, spec.screenshot);

Kenzitron commented 7 years ago

This is already done. Will update npm as soon as possible.

Thanks!