Kephson / paste_reference

Paste reference instead of copy for content elements in TYPO3
MIT License
14 stars 20 forks source link

[FEATURE] Typo3 12 support #21

Open ifre opened 1 year ago

ifre commented 1 year ago

Hi, is a Typo3 12 support planned? An Update would made my day. :D

Thanks a lot

Kephson commented 1 year ago

Hi, yes it's planned and I was asked to add a feature request for TYPO3 core. At the moment I have to check until I can provide an update.

spoonerWeb commented 1 year ago

What's the status here? You won't get a new feature to v12 into the core now. 🙂

Kephson commented 1 year ago

Hey @spoonerWeb yes, you're right :rofl:, I think it's now more than expected to do; pull request is welcome :wink:

cyrakoenig commented 1 year ago

What is the current situation here? Miss paste reference for my TYPO3 12 project ;)

Kephson commented 1 year ago

Hi @cyrakoenig you're welcome to send a pull request, atm I didn't find any time to update it for TYPO3 12. :open_mouth:

spoonerWeb commented 11 months ago

Are there any new plans? 😬

Kephson commented 11 months ago

Hi, there is a new branch for TYPO3 12.4 with preparations for v12, but the backend JavaScript is the hardest part and we need somebody to realize it with ES6.

spoonerWeb commented 10 months ago

@Kephson Do you have someon who can handle the JS issues? I would sponsor it. Customer needs it urgently and I can't handle the JS.

Kephson commented 10 months ago

currently it should work with the versions "dev-main", "dev-TYPO3_12" and "dev-development". Just do a right click and select "paste reference after" to insert a reference after current elements.

Kephson commented 10 months ago

there are a lot of tests needed, at the moment also the EXT: doesn't work with mulitlanguage pages.

Shotte commented 10 months ago

@Kephson Any progress here?

I tried "dev-main" and "dev-TYPO3_12" branches by downloding as zip installing via backend into Typo3 v12.4.8. After following your advice by "doing a right click and select "paste reference after" to insert a reference after current elements" I get this error message: "1: The record "Reference" couldn't be saved due to disallowed value(s)."

Any ideas?

Kephson commented 10 months ago

Hi @Shotte I will try to follow your problems and test the integration.

christophlehmann commented 8 months ago

Nice Extension! Works so far in v12, but only via Context Menu. Would be a nice TYPO3 v13 core feature.

Kephson commented 8 months ago

Hi @christophlehmann yes, current version only via context menu, but it's 90% done in the development branch to have the "insert reference" button again; at the moment the database handling is missing to finish this functionality. I'm working on it and then I will try to bring this to core in TYPO3 v13.

christophlehmann commented 8 months ago

I have installed EXT:container. In a two column container element i have a header element. When i use "Paste after as reference", then the new reference is created as an "unused element" and not in the container after the header element.

Bildschirmfoto 2024-01-29 um 14 21 24

Payload paste reference after

Bildschirmfoto 2024-01-29 um 14 35 30

Payload copy after

Bildschirmfoto 2024-01-29 um 14 35 20
saitho commented 7 months ago

Right now I get a JS error when loggin in as an editor, where top.pasteReferenceAllowed is empty, resulting in:

Uncaught SyntaxError: Unexpected token ';'

The issue lies in https://github.com/Kephson/paste_reference/blob/TYPO3_12/Classes/Hooks/PageLayoutController.php#L99, where the boolean return value from the PHP function is not processed into a boolean value for JavaScript. Casting to (int) may be sufficient, haven't checked the JS implementation yet.

Kephson commented 7 months ago

You could try to use the version dev-TYPO3_12 form packagist to test the problem with the JS error. Did not had the time to check this in detail. I'm still working on a version with all old features in the dev-development version.

ulrichmathes commented 3 months ago

See #37 for reference preview (blue background and Edit button).

DavidBruchmann commented 2 days ago

In https://github.com/DavidBruchmann/paste_reference/tree/david-v12.4 the additional button is now working, to paste content from another page. I'll proceed working, to get the common modal with three options (cancel, paste as copy, paste as reference) working. Of course I'll provide a PR when I'm finished.

@ulrichmathes perhaps you can explain more detailed some GUI related aspects?