Closed JeffLCoughlin closed 5 years ago
Hi Jeff, They look great. My only comment is that you should add a link to the pipeline release page (Release 21) and that we can delete the note under Release 22 saying that r21 is pending.
-Doug
— Douglas Caldwell dacmess@gmail.com
On Jul 11, 2018, at 6:49 PM, Jeff Coughlin notifications@github.com wrote:
Finished off C2 notes. Going to squash and merge, and make some more minor re-organizational tweaks to the DRN page with either a direct master change or a new branch. Doug I'm kind of charging ahead here to get this out before the MMR tomorrow, so if you do get a chance to look it over and have any edits/comments or notice typos, we can update on Master. I gave it a good read-over twice though at the end so don't expect anything major.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/KeplerGO/KeplerScienceWebsite/pull/141#issuecomment-404363813, or mute the thread https://github.com/notifications/unsubscribe-auth/AS8uvnpKtSx5NXXx8Hp6ajJLEp2r8GXcks5uFqszgaJpZM4UTq39.
They look great. My only comment is that you should add a link to the pipeline release page (Release 21) and that we can delete the note under Release 22 saying that r21 is pending.
Great catch - just commenting here for record I updated the pipeline release page in another push to address.
Finished off C2 notes. Going to squash and merge, and make some more minor re-organizational tweaks to the DRN page with either a direct master change or a new branch. Doug I'm kind of charging ahead here to get this out before the MMR tomorrow, so if you do get a chance to look it over and have any edits/comments or notice typos, we can update on Master. I gave it a good read-over twice though at the end so don't expect anything major.