search

KerbalKore / CWPT

Cold War Progression
GNU General Public License v3.0
1 stars 3 forks source link

BDB PR? #28

Closed KerbalKore closed 4 years ago

KerbalKore commented 5 years ago

Cobalt made a request that we make a pull to BDB that adds the tag to it, both for simplicity and a test of mod presupporting. Shall we begin this? @DeltaDizzy @zorg2044 @CobaltWolf

DeltaDizzy commented 5 years ago

I dont see why not. I already have a fork so i can start putting them in.

KerbalKore commented 5 years ago

@DeltaDizzy your branch is 345 commits behind, so around 100 or so parts is my guess. i would say we make a new fork.

DeltaDizzy commented 5 years ago

@KerbalKore you do realize i can just make a PR from BDB to my fork and update it, right?

DeltaDizzy commented 5 years ago

Agena is in, Apollo mapped out, will start Apollo later today. That begs the question though, @KerbalKore are all apollo parts tagged? (includes AARDV. LEM, Apollo blk. 1,2,3,4,5, docking lights)

KerbalKore commented 5 years ago

All the blocks are tagged, along with the LEM, but I'm and idiot and completely forgot about AARDV and the docking lights. I'll get on those. @DeltaDizzy

KerbalKore commented 5 years ago

AARDV and lights tagged @DeltaDizzy

DeltaDizzy commented 5 years ago

Also make sure you have Atlas and Centaur/Vega finished, as they are next. Atlas does not only include SM65, but also Muo, CELV, and Atlas I/II/III if they exist.

KerbalKore commented 5 years ago

I’ve tagged Muo and Atlas Sm65 through 3, but the node for atlas 1/2/3 aren’t finalized yet. I’ll try to make them work. CELV is not started yet, I’ll work on those today.

KerbalKore commented 5 years ago

Centaur is mostly tagged, but it’s nodes aren’t finished yet.

DeltaDizzy commented 5 years ago

As of now SLV-3X is in, and ALL Atlases have been scoped for the current PR. This includes CELV. In addition, I want to try and get the PRs finished by the 25th, as that is the current BDB 1.6.0 due date on that repo. Tagging is more important than nodes, as the tags (hopefully) wont need to shift around if the nodes change, and the tags are what go into BDB.

DeltaDizzy commented 5 years ago

@KerbalKore I dont quite get how you expect to PR into my BDB fork if yours is not a fork of mine or vice versa. They both branch off of Cobalts, but that is only useful when PRing to or from his.

KerbalKore commented 5 years ago

the pr is already open @DeltaDizzy.

DeltaDizzy commented 5 years ago

Titan is merged, now making checklist for Gemini/MOL. We probably can't get it in before Development -> master for 1.6.0, but maybe we can get it for 1.6.1 or 1.6.2.

KerbalKore commented 5 years ago

👍

DeltaDizzy commented 5 years ago

@KerbalKore Some gemini parts are not tagged (for now just the heatshields) In addition, there is BDB's Rumble Gemini. (aka small Big G, 1.875m Leo extension as opposed to 2.5) would that merit a new node? Current tag is "geminiplus"

KerbalKore commented 5 years ago

Hmm

KerbalKore commented 5 years ago

Geminiplus will be good for 1.0

DeltaDizzy commented 5 years ago

@KerbalKore C E A S E

DeltaDizzy commented 5 years ago

why not do the new branch -> squash into development -> merge to cobalt thing i told you about yesterday?

KerbalKore commented 5 years ago

uh

KerbalKore commented 5 years ago

because i forgot and am too far into the depths

DeltaDizzy commented 5 years ago

also your whitespace looks like a literal disease

DeltaDizzy commented 5 years ago

@KerbalKore not to be a dick but if you want me to be thorough I can be, re: readme pr

KerbalKore commented 5 years ago

please do

KerbalKore commented 5 years ago

i need advice from people with experience

DeltaDizzy commented 4 years ago

no longer an open question, we are doing this