Constructive Criticisms

KerbalKore / CWPT

Cold War Progression

GNU General Public License v3.0

1 stars 3 forks source link

Constructive Criticisms #8

Closed DeltaDizzy closed 5 years ago

DeltaDizzy commented 5 years ago

Changes required to make it functional

NEEDS[BluedogDesignBureau] should be changed to NEEDS[Bluedog_DB]
@techtag should be changed to techtag or %techtag unless they are inserted into every part before the support patches run.

Style

CWPT/CWPT/ModSupport/BDB/BDB,cfg Why have a folder for BDB if it will only have one file? It may be better to split part families into their own files. i.e. Titan.cfg, Apollo.cfg, Saturn.cfg, Gemini.cfg, etc.

KerbalKore commented 5 years ago

Good idea. I’ll do those when I get home from school.

KerbalKore commented 5 years ago

Done.

DeltaDizzy commented 5 years ago

But is Titan III still tagged as Titan II?

KerbalKore commented 5 years ago

there was no titan III node, so I figured the Titan 3 stuff should be stored in Titan 2 until we get to nodes