search

Kermalis / VGMusicStudio

🎵 A program that lets you listen to the music from popular video game formats. 🎵
GNU Lesser General Public License v3.0
264 stars 32 forks source link

Fixed MP2K Pitch Bend Range MIDI event write #93

Closed pianistrevor closed 3 years ago

pianistrevor commented 3 years ago

Originally, the event was writing with an undefined controller. This fix writes using the RPN controllers (0,0) and coarse data entry of the range (in semitones).

Kurausukun commented 3 years ago

I'm against this since it makes converting back to .s not work correctly anymore. The CC mapping previously used is what mid2agb uses and maps to the internal number of the m4a event.

pianistrevor commented 3 years ago

I see. So it's a question of whether we output to official MIDI spec or .s standard. I don't use mid2agb so I'll keep my fork for my own use, but it makes sense.

Kermalis commented 3 years ago

I discussed it in the Discord server so in case you didn't know, I would rather have an options panel that shows up before you export the MIDI. Having this as an option just makes sense but it'd have to be implemented with the panel

pianistrevor commented 3 years ago

Sounds good. I might keep this fork around and go fix some other general MIDI options like LFO once you plan to implement the panel. I’ll keep this PR closed until then