Closed dcantrell closed 1 year ago
Overall this looks good but I would prefer if the whitespace errors were corrected before submission.
git rebase --whitespace=fix
For authorship please use
git commit --author="Kermit Project kermit@kermitproject.org"
At least for Frank's code drops.
Thank you for setting the author date (git commit --date) to the timestamp of the tarball.
Frank often fails to clean out his work files before he creates a tarball. In beta.05 for example there are
I remove these work files from the tree before I create the commit. Since we have a git repository prior versions can be extracted from that.
I have merged the commit with the above changes as 0c0c21f5bd29605a256360c749d699e11f105c18
Overall this looks good but I would prefer if the whitespace errors were corrected before submission.
git rebase --whitespace=fix
Noted.
For authorship please use
git commit --author="Kermit Project kermit@kermitproject.org"
I was pretty sure I changed that as well, but if I didn't then I forgot while also fixing the timestamp.
At least for Frank's code drops.
Thank you for setting the author date (git commit --date) to the timestamp of the tarball.
That just felt correct to do.
Frank often fails to clean out his work files before he creates a tarball. In beta.05 for example there are
* ckcnet-BEFORE-NONET-FIX.c * ckuus7-beta02.c * ckuus7-save.c
I remove these work files from the tree before I create the commit. Since we have a git repository prior versions can be extracted from that.
Noted, I will make sure to clean those up.
I have merged the commit with the above changes as 0c0c21f
Sounds good. I will prepare a PR for the next release after this one and continue forward.
Frank was also asking about my membership in both the organization and the project, he may reach out to you for some help.
With changes 4-8 listed above, SSL builds generate no errors or warnings in OpenSSL 1.1.1d-fips 11 Feb 2013 (Red Hat 6.1) nor in OpenSSL 1.1.1f 11 Feb 2020 (Ubuntu 20.4.1). A few warnings are generated in OpenSSL 1.1.f 31 Mar 2020 on NetBSD 9.2. In all three cases compilation and linking succeed and a C-Kermit executable is produced.
25 September 2022:
24 September 2022:
19 September 2022:
17 September 2022:
ckcfns.c sdata():
14 September 2022:
ckcfns.c sdata():
ckcfn2.c spack():
Added code to check whether Long Packet capability had been negotiated before deciding to build a long packet.
Corrected an off-by-two error in calculating whether the packet would be have to be in long format.
Before the previous two changes, file transfers from C-Kermit 10.0 (and some of the earlier 9.0.305 developement versions) to E-Kermit would fail. With the changes, they succeed. Also:
ckcdeb.h:
ckcmai.c:
23 August 2022:
Welcome to (herald): pathname(\%0) This message is coming to you from your C-Kermit initialization file: pathname(~/.kermrc)
Welcome to C-Kermit 10.0 OPEN SOURCE: Beta.05, 23 Aug 2022: /net/u/1/f/fdc/beta05/wermit This message is coming to you from your C-Kermit initialization file: /net/u/1/f/fdc/.kermrc
(~/beta05/) C-Kermit>show variable fullversion (fullversion) = 10.0.400 Beta.05 (~/beta05/) C-Kermit>echo (fullversion) (fullversion) = 10.0.400 Beta.05 (~/beta05/) C-Kermit>
19 August 2022:
I removed all the code that supported special version numbers for (in chronological order) Mac Kermit (circa 1985), Kermit/2 (for OS/2), and Kermit 95 (for MS Windows). From now all C-Kermits will identify themselves in the same way, for example:
C-Kermit 10.0 OPEN SOURCE: Beta.05, 19 Aug 2022, for NetBSD 9.2 (64-bit)
17 August 2022:
The second Beta test of C-Kermit for Windows (formerly known as Kermit 95) was released. This work was done by David Goodwin in New Zealand, and any changes he had to make to the non-Windows-specific modules will be incorporated into Beta.05.
Meanwhile more Beta.04 builds on platforms where it was tested previously would be most welcome: macOS (including old versions), HP-UX, MINIX, Solaris versions before 11, etc, not to mention platforms where it has not yet been tested at all: FreeBSD, OpenBSD, AIX, plus any discontinued OS's that are still running somewhere: IRIX, Tru64/Digital Unix, 4.xBSD, NeXTSTEP, System V, DG/UX, SCO, QNX, SINIX, SunOS, Xenix, etc).