KernelFreeze / Litecraft

Open source, clean room implementation of Minecraft Client
MIT License
138 stars 6 forks source link

Does not compile because of glium #28

Open Bixilon opened 4 years ago

Bixilon commented 4 years ago

Expected Behavior ๐Ÿค”

Compile and run

Current Behavior ๐Ÿ˜”

It does not compile:

error: failed to select a version for `glium`.
    ... required by package `litecraft v0.1.0 (/home/moritz/Litecraft)`
versions that meet the requirements `*` are: 0.26.0-alpha3

the package `litecraft` depends on `glium`, with features: `icon_loading` but `glium` does not have these features.

failed to select a version for `glium` which could resolve this conflict

Steps to Reproduce ๐Ÿ˜ฑ

  1. git clone https://github.com/KernelFreeze/Litecraft.git
  2. cargo run

Context (Environment) ๐Ÿคจ

Kubuntu 20.4 with rustc 1.43.0 (4fb7144ed 2020-04-20)

Juliaria08 commented 4 years ago

The same On win 64

TecnaGamer commented 3 years ago

Same on macOS

iceiix commented 3 years ago

The problem seems to be how these local dependencies are specified, somehow picking up version * instead of the git repo. Replacing these sections in Cargo.toml:

[dependencies.conrod]
git = "https://github.com/Litecrafty/conrod"
features = ["glium", "winit"]

[dependencies.glium]
git = "https://github.com/Litecrafty/glium"
features = ["icon_loading"]

with this syntax:

conrod = { git = "https://github.com/Litecrafty/conrod", features = ["glium", "winit"] }
glium = { git = "https://github.com/Litecrafty/glium", features = ["icon_loading"] }

fixes the "glium, with features:icon_loadingbutglium` does not have these features." error, but then it hits: https://github.com/KernelFreeze/Litecraft/issues/21