changed single verticle bar(|) to or in src/dumps/Windows/win.py by gpu name detection line 128

KernelWanderers / OCSysInfo

Basic, high-level and efficient CLI for discovering, outputting and parsing hardware information from the current system.

MIT License

94 stars 14 forks source link

changed single verticle bar(|) to or in src/dumps/Windows/win.py by gpu name detection line 128 #3

Closed mendelsshop closed 3 years ago

kernel-dev commented 3 years ago

This will not yield the intended output. The error described should not happen on Python 3.6 and greater.

Attempting to do what you've done simply yields one of the values, which is not the intended behaviour. Re:

x = { 'x': 2 }
y = { 'y': 3 }

print(x or y) # { 'x': 2 }
print(x | y) # { 'x': 2, 'y': 3 }

mendelsshop commented 3 years ago

ok, but I was on python 3.7 but it worked in 3.9 and 3.10

kernel-dev commented 3 years ago

Thank you for the report.

However, this will soon be replaced with a more sanitised and accurate method of obtaining the Codename of the current CPU, if possible. I will push the changes to experimental as soon as it's finished testing.

kernel-dev commented 3 years ago

Fixed with latest pushes to main.