search

Kertanos / W40kConquest-OCTGN

Warhammer 40k Conquest Game definition for OCTGN
3 stars 10 forks source link

Fix traits on Suffering and Swordwind Farseer #14

Closed blakewedwards closed 8 years ago

blakewedwards commented 8 years ago

Not sure if these are generated from a script, if so I can run it as well to get other corrections that may have been made.

Kertanos commented 8 years ago

thanks for the notification !

blakewedwards commented 8 years ago

No problem, glad to contribute, and a big thanks for maintaining this so we can all play. I noticed that the change didn't actually get merged and from looking at the repo's commit history it appears you have to manually apply each change yourself and make it a versioned update. Not sure if this is for some octgn integration, but seems like it'll make your life as a maintainer much more difficult? Merging the pull requests and tagging releases (the tab two to the right from commits) might be helpful. Anyway, thanks!

Kertanos commented 8 years ago

It's just that i work on the plugin regularly, so the version that is here is the live version, but not the one on my computer, so there is sometimes things that i already changed, and i don't like to check everything everytime, so i usually don't merge ;) Beside this was not really a big change to make in my files ^^