Implement missing `scanned` functionality for Android

anton-patrushev commented 2 years ago

What this PR is about?

This PR adds missed scanned functionality into Android RN module. This is means scanCard method would be resolved with scanned: boolean field. It was implemented just for iOS only before.

List of changes

while preparing Android Intent for presenting CardIOActivity the CardIOActivity.EXTRA_RETURN_CARD_IMAGE with value true was added to request return card image in onActivityResult within Intent data
check for CardIOActivity.EXTRA_CAPTURED_CARD_IMAGE in onActivityResult from received Intent data to understand whether this card was scanned or fully entered manually
readme update (removed "iOS only" labels from the scanned field)

Additional notes

The idea of providing this feature for Android was taken from this native Android SDK issue. Ideally it should be determined using this EXTRA_MANUAL_ENTRY_RESULT extra value, but unfortunately this thing is private I don't have an access to change this, since this react-native-awesome-card-io packages calls the binary under the hood and it's not possible to modify or patch it AFAIK.

anton-patrushev commented 2 years ago

@Kerumen can you take a look plz? It would be great to deliver a new 0.9.1 version with this Android fix.

TheLonelyAstronaut commented 2 years ago

+1,lgtm

Kerumen commented 2 years ago

Thanks for your PR! I'll merge this and release a new version with this change.

Kerumen commented 2 years ago

This was released as v0.9.1! 🎉

Kerumen / react-native-awesome-card-io