search

Keruspe / GPaste

Clipboard management system
BSD 2-Clause "Simplified" License
781 stars 55 forks source link

GNOME 45 support #426

Closed yochananmarqos closed 1 year ago

yochananmarqos commented 1 year ago

There are breaking changes which will require a separate release for 45 and <=44:

See https://gjs.guide/extensions/upgrading/gnome-shell-45.html

yochananmarqos commented 1 year ago

I just tested on GNOME 45.beta. You forgot to bump mutter-clutter from 12 to 13 in the meson.build. I manually did that and the tray icon and application works fine.

However, opening the settings:

The settings of extension GPaste@gnome-shell-extensions.gnome.org had an error:

TypeError: Object is of type GPasteGtk.PreferencesWidget - cannot convert to AdwPreferencesPage

Stack trace:

fillPreferencesWindow@file:///usr/share/gnome-shell/extensions/GPaste@gnome-shell-extensions.gnome.org/prefs.js:13:16
_loadPrefs@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:36:18
async*_init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:21:14
ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:12:4
OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:139:33
async*_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
_wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
Keruspe commented 1 year ago

Yes I noticed that too today

On Fri 25 Aug 2023 at 17:58, Mark Wagie @.***> wrote:

I just tested on GNOME 45.beta. You forgot to bump mutter-clutter from 12 to 13 in the meson.build. I manually did that and the tray icon and application works fine.

However, opening the settings:

The settings of extension @.*** had an error:

TypeError: Object is of type GPasteGtk.PreferencesWidget - cannot convert to AdwPreferencesPage

Stack trace:

@.**@./prefs.js:13:16 @.:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:36:18 @*.**@*.**@.:///org/gnome/Shell/Extensions/js/extensionsService.js:139:33 @.:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35 @.:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34 @.***:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

— Reply to this email directly, view it on GitHub https://github.com/Keruspe/GPaste/issues/426#issuecomment-1693580707, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABWNXSVZTI75JHPF6YUFFTXXDDSLANCNFSM6AAAAAA3UXKE6Q . You are receiving this because you modified the open/close state.Message ID: @.***>

Keruspe commented 1 year ago

Should all be in order now

yochananmarqos commented 1 year ago

Well, the Preferences work now. However, with GNOME 45.rc, clicking on the tray icon just says (Couldn't connect to GPaste daemon). Running gpaste-client dr reports it successfully reexecuted the daemon, but there's no change. This is with or without the AppIndicator and KStatusNotifierItem extension.

yochananmarqos commented 1 year ago

@Keruspe Oops, forgot to tag you just in case since the issue is closed.