[Debug] Consistent scroll zoom behavior when detected with direction or deltas

Keruspe / Germinal

Minimalist vte-based terminal emulator

GNU General Public License v3.0

65 stars 6 forks source link

[Debug] Consistent scroll zoom behavior when detected with direction or deltas #11

Closed bobi32 closed 5 years ago

bobi32 commented 5 years ago

In Germinal 21, when gdk_event_get_scroll_direction fails but gdk_event_get_scroll_deltas does not (which happens now on my laptop, and might be a consequence of your refactoring over last week), the way the zoom-with-scroll works is inverted, i.e.:

<Ctrl><Scroll up> zooms out (font size decreases);
<Ctrl><Scroll down> zooms in (text size increases).

The quite obvious solution towards consistency of the feature was to invert the condition in the incriminated test.

Keruspe commented 5 years ago

Ok, I see what's causing this.

Merging as it's a quick fix but I'll add another patch to fix my usage then (as this commit breaks things for me)

bobi32 commented 5 years ago

My bad, I assumed you weren’t confronted to this case, so I didn’t think the problem could come down to Gnome mouse configuration, hence this commit that turns out to be nothing but a quick hack ^^