search

Keruspe / Germinal

Minimalist vte-based terminal emulator
GNU General Public License v3.0
65 stars 6 forks source link

Germinal won't kill subprocess on SIGTERM #14

Closed julientechdev closed 5 years ago

julientechdev commented 5 years ago

I switched to Germinal full-time since I discovered it has the killer urxvt feature that was missing from Termite: client/daemon mode, all new terminal shells spawn as child of Germinal making it more lightweight.

I must say that I use Geminal with 'zsh' as startup command since I find tmux redundant with my tiling wm sway, launching tmux only on long-running processes and remote applications.

However I just found out than when I kill a terminal window using sway (sending a SITINT and a SIGTERM), the window closes but the zsh subprocess keeps on living as a zombie, keeping whatever program running at the time running and consuming ressources.

Keruspe commented 5 years ago

That’s interesting, will give it a look.

Why do you kill the window instead of just closing it though?

On Wed 20 Feb 2019 at 09:39, Julien Lequertier notifications@github.com wrote:

I switched to Germinal full-time since I discovered it has the killer urxvt feature that was missing from Termite: client/daemon mode, all new terminal shells spawn as child of Germinal making it more lightweight.

I must say that I use Geminal with 'zsh' as startup command since I find tmux redundant with my tiling wm sway, launching tmux only on long-running processes and remote applications.

However I just found out than when I kill a terminal window using sway (sending a SITINT and a SIGTERM), the window closes but the zsh subprocess keeps on living as a zombie, keeping whatever program running at the time running and consuming ressources.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Keruspe/Germinal/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AANm3iUWT_0joQ8TxjOFpTsqFc9Krfczks5vPQmzgaJpZM4bEr1H .

julientechdev commented 5 years ago

In tiling wm we do not have graphical buttons to close a window. The standard keybinding for closing windows on i3 and sway is $mod+Shift+q, and I have the same behaviour on both.

Here's the relevant part from i3 user guide: https://i3wm.org/docs/userguide.html#_closing_windows

I may be wrong on the SIGINT / SIGTERM I found on the sway code, I think they are related to the main sway process. Here's the sway code responsible of closing windows: https://github.com/swaywm/sway/blob/master/sway/commands/kill.c

Keruspe commented 5 years ago

Ok, I think I know why. Will try fixing it soon