search

KessokuTeaTime / Ive-Spoken

[Minecraft Mod] Displays RPG-like dialogs above players' names. I've spoken.
https://modrinth.com/mod/ive-spoken
GNU General Public License v3.0
5 stars 1 forks source link

Non-fatal error when unusual message are tracked in chat #1

Closed ShaneTRS closed 1 year ago

ShaneTRS commented 1 year ago

Relevant line: https://github.com/KrLite/Ive-Spoken/blob/9fcd0a9922e6fb7476c48422e61f720705c0d3d5/src/main/java/net/krlite/ive_spoken/mixin/ChatTracker.java#L20

I fixed the bug locally with the following change:

    if (args.length == 2 && args[1] instanceof MutableText) {

Although non-fatal, it disrupted the chat message appearing in chat. Instead replacing it with a shorthand form of the error.

KrLite commented 1 year ago

Good solve and thanks for contributing! Changes will be made soon in the next version.

KrLite commented 1 year ago

Fixed in v1.0.1.