search

KessokuTeaTime / Knowledges

[Minecraft Mod] What you see is knowledge!
https://modrinth.com/mod/knowledges
GNU General Public License v3.0
7 stars 0 forks source link

[COMPATIBILITY]: Crash on Forge with Sinytra Connector #13

Closed Afrocntrik closed 4 months ago

Afrocntrik commented 4 months ago

Mod Link

https://modrinth.com/mod/connector

Why Should We be Compatible?

From my understanding that Knowledges is attempting to call Modmenu but it's Forge yet I was able to join a world where I wasn't looking at any blocks and then when I did the game crashed, I do apologize for all these issues I have been sending your way.

Steps to Reproduce

  1. Startup Forge 1.20.1-47.2.17 with Sinytra Connector 1.0.0-beta.43.1.20.1 and Knowledges 5.1.2-fabric1.20
  2. Create/Load into World
  3. Either Crash after Generating Terrain... OR
  4. Look at nearest block then crash crashlog.txt
KrLite commented 4 months ago

Sorry for the inconvenience, but this shouldn't be considered a compatibility problem.

  1. Knowledges checks if ModMenu is loaded and gets mod names from it. If it is not loaded, Knowledges won't crash, instead it will find names from other sources. At least this runs well on Fabric.
  2. The dependency chain is correct. Knowledges doesn't require ModMenu but only implements it, so mod loaders should handle the exceptions, instead of crashing them. Knowledges checks if a mod is loaded by using FabricLoader.getInstance().isModLoaded(...), on Fabric, this method returns real conditions, but the connector may be messing it up.
  3. I hereby also declare that before an official Forge version is made, I don't guarantee any usability, compatibility, or stability of Knowledges on Forge as I'm not obligated to do that.

However, a simple solution might be just installing ModMenu along, however, you might have to install it also through connector, and to be honest, I'm not very familiar with connector or so, so it's just a vague solution.

KrLite commented 4 months ago

As the reasons mentioned above, this issue will be labeled wontfix and closed.