[BUG] Music notations typos

[ESEAbsolute]

Mod Loader

Fabric

Minecraft Version

1.20.2

What Happened?

I reviewed your code NoteBlockData.java and found several typos in notations.

1. GERMANIC

   • L205: m -> m.map("Ais3", "H3"), -> m -> m.map("Ais3", "B3"),
   • L206: m -> Text.literal("B3"), -> m -> Text.literal("H3"),
   • L217: m -> m.map("Ais4", "H4"), -> m -> m.map("Ais4", "B4"),
   • L218: m -> Text.literal("B4"), -> m -> Text.literal("H4"), In germanic notations, B is actually B-flat, and H is actually B. Reference: Why is the musical scale C D E F G A H? Why is there an H between A and C instead of B?

2. JAPANESE

   • L262, L263, L264, L274, L275, L276: 二 -> ニ The former one in the code is actually Hanzi/Kanji character U+4E8C; the latter is Japanese Katakana U+30CB.

3. CHINESE I take "Chinese Pentatonic Scale" on Wikipedia as reference, I have not found that these "宫商角徵羽" can be connected with "升" and "降". Hope you can provide me further information.

---

Translations may be inaccurate or problematic, here is the Chinese version:

我看了你的 NoteBlockData.java 代码发现了一些音符记法上的问题。

1. 德式

   • L205: m -> m.map("Ais3", "H3"), -> m -> m.map("Ais3", "B3"),
   • L206: m -> Text.literal("B3"), -> m -> Text.literal("H3"),
   • L217: m -> m.map("Ais4", "H4"), -> m -> m.map("Ais4", "B4"),
   • L218: m -> Text.literal("B4"), -> m -> Text.literal("H4"), 根据我查找到的资料，在德式记法中 B 实际上指的是降 B，而 H 指的是 B。参考资料：Why is the musical scale C D E F G A H? Why is there an H between A and C instead of B?

2. 日式

   • L262, L263, L264, L274, L275, L276: 二 -> ニ 前者是汉字「二」U+4E8C，后者是日文片假名「ニ」。两者差距还是挺大的。

3. 中式

根据 中国五声音阶 页面，我没看到有写可以升降。希望可以给更多资料解释一下。

What Should Happen?

No response

Steps to Reproduce

Not related to the reproduction process

与复现过程无关

Crash Log

No response

Anything Else?

No response

[ESEAbsolute]

Further information / 补充资料：

「ドイツ語は英語とほぼ同様だが、「B」は英語の「B♭」に相当し、英語の「B」にあたる音は「H」と呼ぶ。派生音は♯をつける代わりに音名に「-is」を後置し、♭をつけるかわりに「-es」（母音のAとEの場合は単に「-s」）を後置する。」

Translation by ChatGPT:

• English: "German is almost the same as English, but "B" corresponds to English "B♭," and the note equivalent to English "B" is called "H." For derivative notes, instead of adding a sharp (♯), "-is" is appended to the note name, and for a flat (♭), "-es" is added (for vowels A and E, simply "-s" is used)."
• 中文：「德语与英语几乎相同，但「B」相当于英语的「B♭」，而与英语的「B」相对应的音被称为「H」。在派生音方面，德语使用「-is」后缀来表示升音符号♯，而使用「-es」（对于母音A和E，只加「-s」）来表示降音符号♭。」

Source / 来源：https://ja.wikipedia.org/wiki/%E9%9F%B3%E5%90%8D%E3%81%A8%E9%9A%8E%E5%90%8D

[KrLite]

Thanks for reporting!

1. The Germanic notation is indeed wrongly mapped 😵‍💫, I'll fix it in the next possible version.
2. I was literally typing Katakanas using a Chinese IME so... it's my fault not noticing the different Unicode representations, I'll fix it in the next possible version.
3. In traditional Chinese scales, we have 变宫 for B and 清角 for F, however, these aren't enough for representing all the possible musical notations including arbitrary sharps and flats. Thus, I decided to use 升(sharp) and 降(flat) to prefix the notations. I made them up out of thin air just to make everything clearer. However, if you have a better interpretation, please tell me! This will be kept until other workarounds are found.

Thanks for your corrections! They helped a lot :)

[ESEAbsolute]

Thanks for reporting!

1. The Germanic notation is indeed wrongly mapped 😵‍💫, I'll fix it in the next possible version.
2. I was literally typing Katakanas using a Chinese IME so... it's my fault not noticing the different Unicode representations, I'll fix it in the next possible version.
3. In traditional Chinese scales, we have 变宫 for B and 清角 for F, however, these aren't enough for representing all the possible musical notations including arbitrary sharps and flats. Thus, I decided to use 升(sharp) and 降(flat) to prefix the notations. I made them up out of thin air just to make everything clearer. However, if you have a better interpretation, please tell me! This will be kept until other workarounds are found.

Thanks for your corrections! They helped a lot :)

我觉得这个能帮到你 十二律 这个和十二平均律很像，但是感觉很少人能看懂，宫商角徵羽更普遍一些吧。中式记法这里还是我欠考虑了

I think this can help you: Shi'er lü is quite similar to the twelve-tone equal temperament, but it seems that very few people can understand it. The names of the notes, 宫商角徵羽, are more commonly known. I realize I haven't considered enough here, sorry.

[KrLite]

Thanks for reporting!

1. The Germanic notation is indeed wrongly mapped 😵‍💫, I'll fix it in the next possible version.
2. I was literally typing Katakanas using a Chinese IME so... it's my fault not noticing the different Unicode representations, I'll fix it in the next possible version.
3. In traditional Chinese scales, we have 变宫 for B and 清角 for F, however, these aren't enough for representing all the possible musical notations including arbitrary sharps and flats. Thus, I decided to use 升(sharp) and 降(flat) to prefix the notations. I made them up out of thin air just to make everything clearer. However, if you have a better interpretation, please tell me! This will be kept until other workarounds are found.

Thanks for your corrections! They helped a lot :)

我觉得这个能帮到你 十二律 这个和十二平均律很像，但是感觉很少人能看懂，宫商角徵羽更普遍一些吧。中式记法这里还是我欠考虑了

I think this can help you: Shi'er lü is quite similar to the twelve-tone equal temperament, but it seems that very few people can understand it. The names of the notes, 宫商角徵羽, are more commonly known. I realize I haven't considered enough here, sorry.

I'll just keep it unchanged for now.

ps: I made a mistake in the previous statements and here's the corrected one:

we have 变宫 for B and 清角 for F