KrLite
commented
1 month ago That's such an interesting feature! I didn't notice that when I read the vanilla code. It's definitely ok to add a feature like that, but since I'm not currently working on Java for a period of time, I'm sorry that updates may delay.
Thanks for proposing and I'll work on it once I come back to write Java again.
Mod Loader
Fabric
Minecraft Version
1.21.1
What Happened?
The splash that is under the translationkey ID "222" in the textfile gets used by default, when it isn't supposed to be, and there does not seem to be a relevant config toggle to disable it.
In the vanillagame, since translationkeys for splashes don't exist there, there is instead a hardcoded function that stops a splash that matches "This message will never appear on the splash screen, isn't that weird?" from being printed onscreen, being skipped in the random selection. It makes sense if this was simply missed when making the mod, since it looks like any other splash besides its self-explaining message.
I noticed the inconsistency when I started work on a resource pack to translate/localize the splashes into german.
What Should Happen?
Any splash under the translationkey "splash.minecraft.222" does not render onscreen unless the user actually wants it(requires new config toggle to seperately handle the intentionally hidden Splash text with default value false).
Steps to Reproduce
1: Use the mod 2: The relevant Splash is in the pool of messages to show on the title screen 3: Discover the splash actually exists to begin with(I honestly don't think I knew beforehand)
Crash Log
No response
Anything Else?
This is an amazingly cool mod. I wish a feature like this was available for every version of MC by default, but alas...