Ketho / vscode-wow-api

VS Code extension for World of Warcraft AddOns
https://marketplace.visualstudio.com/items?itemName=ketho.wow-api
MIT License
142 stars 31 forks source link

Something wrong with GetCategoryNumAchievements #137

Closed Etern213 closed 5 months ago

Etern213 commented 5 months ago

According to https://warcraft.wiki.gg/wiki/API_GetCategoryNumAchievements

total, completed, incompleted = GetCategoryNumAchievements(categoryId[, includeAll])

includeAll can be nil

so maybe we should change

---[Documentation](https://warcraft.wiki.gg/wiki/API_GetCategoryNumAchievements)
---@param categoryId number
---@param includeAll boolean
---@return number total
---@return number completed
---@return number incompleted
function GetCategoryNumAchievements(categoryId, includeAll) end

to

---[Documentation](https://warcraft.wiki.gg/wiki/API_GetCategoryNumAchievements)
---@param categoryId number
---@param includeAll boolean?
---@return number total
---@return number completed
---@return number incompleted
function GetCategoryNumAchievements(categoryId, includeAll) end